sis190: mdio operation failure is not correctly detected
authorFrancois Romieu <romieu@fr.zoreil.com>
Sat, 17 Nov 2007 15:56:43 +0000 (16:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 23 Jan 2008 11:11:45 +0000 (03:11 -0800)
i ranges from 0 to 100 in the 'for' loop a few lines above.

Reported by davem.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: K.M. Liu <kmliu@sis.com.tw>
drivers/net/sis190.c

index 92e0eb95ff8c548a8b316c118f588916fcbeef2f..342a986214c86cb5f09e2c1af374059bda0782fe 100644 (file)
@@ -372,7 +372,7 @@ static void __mdio_cmd(void __iomem *ioaddr, u32 ctl)
                msleep(1);
        }
 
-       if (i > 999)
+       if (i > 99)
                printk(KERN_ERR PFX "PHY command failed !\n");
 }