rtc: snvs: add a missing write sync
authorGuy Shapiro <guy.shapiro@mobi-wize.com>
Sun, 29 Jan 2017 09:57:19 +0000 (11:57 +0200)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Wed, 1 Feb 2017 11:44:24 +0000 (12:44 +0100)
The clear of the LPTA_EN flag should be synced before writing to the
alarm register. Omitting this synchronization creates a race when
trying to change existing alarm.

Signed-off-by: Guy Shapiro <guy.shapiro@mobi-wize.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-snvs.c

index 0f11c2a228e35a02033e1b64dcddc6f5599927cd..d51b07d620f7bd6fadbbf66f666870d8e50516f0 100644 (file)
@@ -184,6 +184,7 @@ static int snvs_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
        rtc_tm_to_time(alrm_tm, &time);
 
        regmap_update_bits(data->regmap, data->offset + SNVS_LPCR, SNVS_LPCR_LPTA_EN, 0);
+       rtc_write_sync_lp(data);
        regmap_write(data->regmap, data->offset + SNVS_LPTAR, time);
 
        /* Clear alarm interrupt status bit */