cec: Fix coverity error [1/1]

PD#SWPL-13936

Problem:
Fix coverity error.

Solution:
Fix coverity error.

Verify:
TL1

Change-Id: I3e1af9370b47c1c9e06634f6cd4d04b2a229d664
Signed-off-by: Yong Qin <yong.qin@amlogic.com>

diff --git a/drivers/amlogic/cec/hdmi_ao_cec.c b/drivers/amlogic/cec/hdmi_ao_cec.c
index decb564a73e7c0704e769db1cff0e8954f226b2a..d8b91fa6f6f52a57d8e882e31265dc47aca439cc 100644 (file)
--- a/drivers/amlogic/cec/hdmi_ao_cec.c
+++ b/drivers/amlogic/cec/hdmi_ao_cec.c
@@ -2462,7 +2462,7 @@ static ssize_t cmda_store(struct class *cla, struct class_attribute *attr,
        for (i = 0; i < cnt; i++)
                buf[i] = (char)tmpbuf[i];
 
-       if (cec_dev && (cec_dev->cec_num > ENABLE_ONE_CEC))
+       if (cec_dev->cec_num > ENABLE_ONE_CEC)
                ceca_trigle_tx(buf, cnt);
        else
                CEC_ERR("ceca not valid\n");
@@ -2491,7 +2491,7 @@ static ssize_t cmdb_store(struct class *cla, struct class_attribute *attr,
        for (i = 0; i < cnt; i++)
                buf[i] = (char)tmpbuf[i];
 
-       if (cec_dev && (cec_dev->cec_num > ENABLE_ONE_CEC))
+       if (cec_dev->cec_num > ENABLE_ONE_CEC)
                cecb_trigle_tx(buf, cnt);
        else
                CEC_ERR("cecb not valid\n");

diff --git a/drivers/amlogic/cec/hdmi_ao_cec.h b/drivers/amlogic/cec/hdmi_ao_cec.h
index 9fedb599a52feab8b0ddb4637346dddee88335f0..0a4f6b99f6c3b0edeb2cfb0e8ca9fa443b1d65d6 100644 (file)
--- a/drivers/amlogic/cec/hdmi_ao_cec.h
+++ b/drivers/amlogic/cec/hdmi_ao_cec.h
@@ -18,7 +18,7 @@
 #ifndef __AO_CEC_H__
 #define __AO_CEC_H__
 
-#define CEC_DRIVER_VERSION     "2019/7/11: pretect resume received OTP again msg\n"
+#define CEC_DRIVER_VERSION     "2019/10/11: Fix coverity error\n"
 
 #define CEC_FRAME_DELAY                msecs_to_jiffies(400)
 #define CEC_DEV_NAME           "cec"