net: cdc_ncm: error path lock fix
authorBjørn Mork <bjorn@mork.no>
Thu, 25 Oct 2012 21:44:09 +0000 (21:44 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 28 Oct 2012 23:07:58 +0000 (19:07 -0400)
Fixes the sparse warning

 drivers/net/usb/cdc_ncm.c:836:9: warning: context imbalance in 'cdc_ncm_txpath_bh' - different lock contexts for basic block

Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_ncm.c

index 397de6396da6b20cc3c5191fd7ebff569c2fb119..ddc7b8880f60894a1470c504d49f06aee0c33910 100644 (file)
@@ -819,6 +819,8 @@ static void cdc_ncm_txpath_bh(unsigned long param)
                netif_tx_lock_bh(ctx->netdev);
                usbnet_start_xmit(NULL, ctx->netdev);
                netif_tx_unlock_bh(ctx->netdev);
+       } else {
+               spin_unlock_bh(&ctx->mtx);
        }
 }