Bluetooth: Add __hci_cmd_sync_ev function
authorJohan Hedberg <johan.hedberg@intel.com>
Wed, 3 Apr 2013 18:54:47 +0000 (21:54 +0300)
committerJohan Hedberg <johan.hedberg@intel.com>
Thu, 4 Apr 2013 16:16:10 +0000 (19:16 +0300)
This patch adds a __hci_cmd_sync_ev function, analogous to
__hci_cmd_sync except that it also takes an event parameter to indicate
that the command completes with a special event instead of command
complete. Internally this new function takes advantage of the
hci_req_add_ev function introduced in the previous patch.

The primary expected user of this new function are the setup routines of
HCI drivers which may want to send custom commands and return only when
they have completed.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
include/net/bluetooth/hci_core.h
net/bluetooth/hci_core.c

index b85eefb230fd26299e2486c71a7dbeec62577406..47129b1ee20bf4c9407fa084d1ee684c981ac170 100644 (file)
@@ -1061,6 +1061,8 @@ void hci_req_cmd_complete(struct hci_dev *hdev, u16 opcode, u8 status);
 
 struct sk_buff *__hci_cmd_sync(struct hci_dev *hdev, u16 opcode, u32 plen,
                               void *param, u32 timeout);
+struct sk_buff *__hci_cmd_sync_ev(struct hci_dev *hdev, u16 opcode, u32 plen,
+                                 void *param, u8 event, u32 timeout);
 
 int hci_send_cmd(struct hci_dev *hdev, __u16 opcode, __u32 plen, void *param);
 void hci_send_acl(struct hci_chan *chan, struct sk_buff *skb, __u16 flags);
index 7f1413cae2cbc0292353ab2b60ecf0144220dd92..9567e32a1f0c43b9e494370a57ac58bb750ae208 100644 (file)
@@ -79,7 +79,7 @@ static void hci_req_cancel(struct hci_dev *hdev, int err)
        }
 }
 
-struct sk_buff *hci_get_cmd_complete(struct hci_dev *hdev, u16 opcode)
+struct sk_buff *hci_get_cmd_complete(struct hci_dev *hdev, u16 opcode, u8 event)
 {
        struct hci_ev_cmd_complete *ev;
        struct hci_event_hdr *hdr;
@@ -103,6 +103,12 @@ struct sk_buff *hci_get_cmd_complete(struct hci_dev *hdev, u16 opcode)
        hdr = (void *) skb->data;
        skb_pull(skb, HCI_EVENT_HDR_SIZE);
 
+       if (event) {
+               if (hdr->evt != event)
+                       goto failed;
+               return skb;
+       }
+
        if (hdr->evt != HCI_EV_CMD_COMPLETE) {
                BT_DBG("Last event is not cmd complete (0x%2.2x)", hdr->evt);
                goto failed;
@@ -127,8 +133,8 @@ failed:
        return ERR_PTR(-ENODATA);
 }
 
-struct sk_buff *__hci_cmd_sync(struct hci_dev *hdev, u16 opcode, u32 plen,
-                              void *param, u32 timeout)
+struct sk_buff *__hci_cmd_sync_ev(struct hci_dev *hdev, u16 opcode, u32 plen,
+                                 void *param, u8 event, u32 timeout)
 {
        DECLARE_WAITQUEUE(wait, current);
        struct hci_request req;
@@ -138,7 +144,7 @@ struct sk_buff *__hci_cmd_sync(struct hci_dev *hdev, u16 opcode, u32 plen,
 
        hci_req_init(&req, hdev);
 
-       hci_req_add(&req, opcode, plen, param);
+       hci_req_add_ev(&req, opcode, plen, param, event);
 
        hdev->req_status = HCI_REQ_PEND;
 
@@ -177,7 +183,14 @@ struct sk_buff *__hci_cmd_sync(struct hci_dev *hdev, u16 opcode, u32 plen,
        if (err < 0)
                return ERR_PTR(err);
 
-       return hci_get_cmd_complete(hdev, opcode);
+       return hci_get_cmd_complete(hdev, opcode, event);
+}
+EXPORT_SYMBOL(__hci_cmd_sync_ev);
+
+struct sk_buff *__hci_cmd_sync(struct hci_dev *hdev, u16 opcode, u32 plen,
+                              void *param, u32 timeout)
+{
+       return __hci_cmd_sync_ev(hdev, opcode, plen, param, 0, timeout);
 }
 EXPORT_SYMBOL(__hci_cmd_sync);