s390: do not bypass BPENTER for interrupt system calls
authorMartin Schwidefsky <schwidefsky@de.ibm.com>
Fri, 27 Apr 2018 05:36:50 +0000 (07:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Apr 2018 09:31:59 +0000 (11:31 +0200)
[ Upstream commit d5feec04fe578c8dbd9e2e1439afc2f0af761ed4 ]

The system call path can be interrupted before the switch back to the
standard branch prediction with BPENTER has been done. The critical
section cleanup code skips forward to .Lsysc_do_svc and bypasses the
BPENTER. In this case the kernel and all subsequent code will run with
the limited branch prediction.

Fixes: eacf67eb9b32 ("s390: run user space and KVM guests with modified branch prediction")
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/s390/kernel/entry.S

index 8cbe75d7353d861de7ae82069c28acc2f1879562..c3e28af207cf55a9a782577f9f4ca4b6e23f3991 100644 (file)
@@ -1316,7 +1316,8 @@ cleanup_critical:
        srag    %r9,%r9,23
        jz      0f
        mvc     __TI_last_break(8,%r12),16(%r11)
-0:     # set up saved register r11
+0:     BPENTER __TI_flags(%r12),_TIF_ISOLATE_BP
+       # set up saved register r11
        lg      %r15,__LC_KERNEL_STACK
        la      %r9,STACK_FRAME_OVERHEAD(%r15)
        stg     %r9,24(%r11)            # r11 pt_regs pointer