ibmvnic: convert to use simple_open()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 24 Aug 2016 13:50:03 +0000 (13:50 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Aug 2016 23:40:38 +0000 (16:40 -0700)
Remove an open coded simple_open() function and replace file
operations references to the function with simple_open()
instead.

Generated by: scripts/coccinelle/api/simple_open.cocci

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index b942108c85c1bc6566056282b5d8d7705b121685..e8625309bfb2c344cd858a50a3e720386f919ce9 100644 (file)
@@ -2779,12 +2779,6 @@ static void handle_control_ras_rsp(union ibmvnic_crq *crq,
        }
 }
 
-static int ibmvnic_fw_comp_open(struct inode *inode, struct file *file)
-{
-       file->private_data = inode->i_private;
-       return 0;
-}
-
 static ssize_t trace_read(struct file *file, char __user *user_buf, size_t len,
                          loff_t *ppos)
 {
@@ -2836,7 +2830,7 @@ static ssize_t trace_read(struct file *file, char __user *user_buf, size_t len,
 
 static const struct file_operations trace_ops = {
        .owner          = THIS_MODULE,
-       .open           = ibmvnic_fw_comp_open,
+       .open           = simple_open,
        .read           = trace_read,
 };
 
@@ -2886,7 +2880,7 @@ static ssize_t paused_write(struct file *file, const char __user *user_buf,
 
 static const struct file_operations paused_ops = {
        .owner          = THIS_MODULE,
-       .open           = ibmvnic_fw_comp_open,
+       .open           = simple_open,
        .read           = paused_read,
        .write          = paused_write,
 };
@@ -2934,7 +2928,7 @@ static ssize_t tracing_write(struct file *file, const char __user *user_buf,
 
 static const struct file_operations tracing_ops = {
        .owner          = THIS_MODULE,
-       .open           = ibmvnic_fw_comp_open,
+       .open           = simple_open,
        .read           = tracing_read,
        .write          = tracing_write,
 };
@@ -2987,7 +2981,7 @@ static ssize_t error_level_write(struct file *file, const char __user *user_buf,
 
 static const struct file_operations error_level_ops = {
        .owner          = THIS_MODULE,
-       .open           = ibmvnic_fw_comp_open,
+       .open           = simple_open,
        .read           = error_level_read,
        .write          = error_level_write,
 };
@@ -3038,7 +3032,7 @@ static ssize_t trace_level_write(struct file *file, const char __user *user_buf,
 
 static const struct file_operations trace_level_ops = {
        .owner          = THIS_MODULE,
-       .open           = ibmvnic_fw_comp_open,
+       .open           = simple_open,
        .read           = trace_level_read,
        .write          = trace_level_write,
 };
@@ -3091,7 +3085,7 @@ static ssize_t trace_buff_size_write(struct file *file,
 
 static const struct file_operations trace_size_ops = {
        .owner          = THIS_MODULE,
-       .open           = ibmvnic_fw_comp_open,
+       .open           = simple_open,
        .read           = trace_buff_size_read,
        .write          = trace_buff_size_write,
 };