ALSA: azt3328: Remove unnecessary synchronize_irq() before free_irq()
authorLars-Peter Clausen <lars@metafoo.de>
Sat, 21 Nov 2015 11:01:22 +0000 (12:01 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 21 Nov 2015 16:40:07 +0000 (17:40 +0100)
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way) before any state associated with the IRQ is freed.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/azt3328.c

index 07a4acc99541da6a4279efdb2a393d91226b028d..5e2ef0bb7057cd9c6c78d60213b6f207ee1888ac 100644 (file)
@@ -2294,8 +2294,6 @@ snd_azf3328_free(struct snd_azf3328 *chip)
        snd_azf3328_timer_stop(chip->timer);
        snd_azf3328_gameport_free(chip);
 
-       if (chip->irq >= 0)
-               synchronize_irq(chip->irq);
 __end_hw:
        if (chip->irq >= 0)
                free_irq(chip->irq, chip);