seq_file: return a negative error code when seq_path_root() fails.
authorTetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Fri, 18 Sep 2009 20:05:59 +0000 (13:05 -0700)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 24 Sep 2009 11:47:29 +0000 (07:47 -0400)
seq_path_root() is returning a return value of successful __d_path()
instead of returning a negative value when mangle_path() failed.

This is not a bug so far because nobody is using return value of
seq_path_root().

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/seq_file.c

index 6c959275f2d0ef41577d9cdb09086f3b9c670883..66efd0aa8fb3b8b36b7067855a9300f6eecbe665 100644 (file)
@@ -470,6 +470,7 @@ int seq_path_root(struct seq_file *m, struct path *path, struct path *root,
                                m->count = s - m->buf;
                                return 0;
                        }
+                       err = -ENAMETOOLONG;
                }
        }
        m->count = m->size;