selftests: watchdog: prefer strtoul() over atoi()
authorEugeniu Rosca <erosca@de.adit-jv.com>
Sat, 1 Jul 2017 12:57:27 +0000 (14:57 +0200)
committerShuah Khan <shuahkh@osg.samsung.com>
Mon, 24 Jul 2017 18:36:47 +0000 (12:36 -0600)
commit f15d7114bbdd ("Documentation/watchdog: add timeout and ping rate
control to watchdog-test.c") used both atoi() and strtoul() for string
to integer conversion. As usage of atoi() is discouraged in newer code,
replace it with strtoul() for consistency.

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
tools/testing/selftests/watchdog/watchdog-test.c

index e7c9d3bdae5661e3cae64d2e7bcd4882cac33dcb..5cfa88c7309517f306fefe547288934236bdad59 100644 (file)
@@ -106,7 +106,7 @@ int main(int argc, char *argv[])
                        printf("Watchdog ping rate set to %u seconds.\n", ping_rate);
                        break;
                case 't':
-                       flags = atoi(optarg);
+                       flags = strtoul(optarg, NULL, 0);
                        ret = ioctl(fd, WDIOC_SETTIMEOUT, &flags);
                        if (!ret)
                                printf("Watchdog timeout set to %u seconds.\n", flags);