virtio: console: remove_port() should return void
authorAmit Shah <amit.shah@redhat.com>
Thu, 2 Sep 2010 12:41:47 +0000 (18:11 +0530)
committerRusty Russell <rusty@rustcorp.com.au>
Thu, 21 Oct 2010 07:14:02 +0000 (17:44 +1030)
When a port is removed, we have to assume the port is gone. So a
success/failure return value doesn't make sense.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/char/virtio_console.c

index 70f1c38fa14cd959efdb534542ea6139b7d8e612..21b621343033a8d3fd82158a3555947812180970 100644 (file)
@@ -1131,7 +1131,7 @@ fail:
 }
 
 /* Remove all port-specific data. */
-static int remove_port(struct port *port)
+static void remove_port(struct port *port)
 {
        struct port_buffer *buf;
 
@@ -1181,7 +1181,6 @@ static int remove_port(struct port *port)
        debugfs_remove(port->debugfs_file);
 
        kfree(port);
-       return 0;
 }
 
 /* Any private messages that the Host and Guest want to share */