f2fs: return proper error from start_gc_thread
authorNamjae Jeon <namjae.jeon@samsung.com>
Sun, 26 May 2013 02:05:32 +0000 (11:05 +0900)
committerJaegeuk Kim <jaegeuk.kim@samsung.com>
Tue, 28 May 2013 06:03:05 +0000 (15:03 +0900)
when there is an error from kthread_run, then return proper error
rather than returning -ENOMEM.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
fs/f2fs/gc.c

index 25b083c81d5003de42c4c8fd4d0b7cd6034b5b26..ddc2c6750eeeeabc0cea4c3b766c6a1d94beb0a5 100644 (file)
@@ -91,23 +91,28 @@ int start_gc_thread(struct f2fs_sb_info *sbi)
 {
        struct f2fs_gc_kthread *gc_th;
        dev_t dev = sbi->sb->s_bdev->bd_dev;
+       int err = 0;
 
        if (!test_opt(sbi, BG_GC))
-               return 0;
+               goto out;
        gc_th = kmalloc(sizeof(struct f2fs_gc_kthread), GFP_KERNEL);
-       if (!gc_th)
-               return -ENOMEM;
+       if (!gc_th) {
+               err = -ENOMEM;
+               goto out;
+       }
 
        sbi->gc_thread = gc_th;
        init_waitqueue_head(&sbi->gc_thread->gc_wait_queue_head);
        sbi->gc_thread->f2fs_gc_task = kthread_run(gc_thread_func, sbi,
                        "f2fs_gc-%u:%u", MAJOR(dev), MINOR(dev));
        if (IS_ERR(gc_th->f2fs_gc_task)) {
+               err = PTR_ERR(gc_th->f2fs_gc_task);
                kfree(gc_th);
                sbi->gc_thread = NULL;
-               return -ENOMEM;
        }
-       return 0;
+
+out:
+       return err;
 }
 
 void stop_gc_thread(struct f2fs_sb_info *sbi)