`StringUtil::encodeJS()` was a bit inefficient for large strings
authorAlexander Ebert <ebert@woltlab.com>
Wed, 13 Mar 2019 12:13:27 +0000 (13:13 +0100)
committerAlexander Ebert <ebert@woltlab.com>
Wed, 13 Mar 2019 12:13:27 +0000 (13:13 +0100)
wcfsetup/install/files/lib/util/StringUtil.class.php

index a50333d66c2ead87d33bbeb4471f0d915948c06d..f96a279925c238f9861935bc180c29e16c9b8a10 100644 (file)
@@ -119,20 +119,8 @@ final class StringUtil {
         * @return      string
         */
        public static function encodeJS($string) {
-               // unify newlines
                $string = self::unifyNewlines($string);
-               
-               // escape backslash
-               $string = str_replace("\\", "\\\\", $string);
-               
-               // escape singe quote
-               $string = str_replace("'", "\'", $string);
-               
-               // escape new lines
-               $string = str_replace("\n", '\n', $string);
-               
-               // escape slashes
-               $string = str_replace("/", '\/', $string);
+               $string = str_replace(["\\", "'", "\n", "/"], ["\\\\", "\'", '\n', '\/'], $string);
                
                return $string;
        }