netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 2 Feb 2015 09:40:30 +0000 (10:40 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Feb 2015 00:22:12 +0000 (16:22 -0800)
The cipso_v4_doi_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlabel/netlabel_cipso_v4.c

index 179625353cacef10c850fed64732f78261714bfe..7fd1104ba9007ec0d731d97d0a245eb3da7b4436 100644 (file)
@@ -324,8 +324,7 @@ static int netlbl_cipsov4_add_std(struct genl_info *info,
        return 0;
 
 add_std_failure:
-       if (doi_def)
-               cipso_v4_doi_free(doi_def);
+       cipso_v4_doi_free(doi_def);
        return ret_val;
 }