projects
/
GitHub
/
LineageOS
/
android_kernel_motorola_exynos9610.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5771a8c
)
ASoC: compress: Delete error messages for a failed memory allocation in snd_soc_new_c...
author
Markus Elfring
<elfring@users.sourceforge.net>
Thu, 10 Aug 2017 14:21:34 +0000
(16:21 +0200)
committer
Mark Brown
<broonie@kernel.org>
Thu, 10 Aug 2017 15:23:07 +0000
(16:23 +0100)
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-compress.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/soc/soc-compress.c
b/sound/soc/soc-compress.c
index 206f36bf43e8b8720db54a8b463305561979a20d..6c867d50e036a72ef10a2b223b1b58acc2aae475 100644
(file)
--- a/
sound/soc/soc-compress.c
+++ b/
sound/soc/soc-compress.c
@@
-764,15
+764,12
@@
int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
direction = SND_COMPRESS_CAPTURE;
compr = kzalloc(sizeof(*compr), GFP_KERNEL);
- if (compr == NULL) {
- snd_printk(KERN_ERR "Cannot allocate compr\n");
+ if (!compr)
return -ENOMEM;
- }
compr->ops = devm_kzalloc(rtd->card->dev, sizeof(soc_compr_ops),
GFP_KERNEL);
- if (compr->ops == NULL) {
- dev_err(rtd->card->dev, "Cannot allocate compressed ops\n");
+ if (!compr->ops) {
ret = -ENOMEM;
goto compr_err;
}