drm/i915: pass seqno to i915_hangcheck_ring_idle
authorMika Kuoppala <mika.kuoppala@linux.intel.com>
Mon, 13 May 2013 13:32:09 +0000 (16:32 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 31 May 2013 18:53:53 +0000 (20:53 +0200)
In preparation for next commit, pass seqno as a parameter
to i915_hangcheck_ring_idle as it will be used inside
i915_hangcheck_elapsed.

Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_irq.c

index 879c4ccb00dbd3306d55ee9244e47a6301928390..0e5c9b0cc5a646aba63dbf734a63eedc16f430b0 100644 (file)
@@ -2274,11 +2274,11 @@ ring_last_seqno(struct intel_ring_buffer *ring)
                          struct drm_i915_gem_request, list)->seqno;
 }
 
-static bool i915_hangcheck_ring_idle(struct intel_ring_buffer *ring, bool *err)
+static bool i915_hangcheck_ring_idle(struct intel_ring_buffer *ring,
+                                    u32 ring_seqno, bool *err)
 {
        if (list_empty(&ring->request_list) ||
-           i915_seqno_passed(ring->get_seqno(ring, false),
-                             ring_last_seqno(ring))) {
+           i915_seqno_passed(ring_seqno, ring_last_seqno(ring))) {
                /* Issue a wake-up to catch stuck h/w. */
                if (waitqueue_active(&ring->irq_queue)) {
                        DRM_ERROR("Hangcheck timer elapsed... %s idle\n",
@@ -2395,7 +2395,10 @@ void i915_hangcheck_elapsed(unsigned long data)
        memset(acthd, 0, sizeof(acthd));
        idle = true;
        for_each_ring(ring, dev_priv, i) {
-           idle &= i915_hangcheck_ring_idle(ring, &err);
+               u32 seqno;
+
+               seqno = ring->get_seqno(ring, false);
+               idle &= i915_hangcheck_ring_idle(ring, seqno, &err);
            acthd[i] = intel_ring_get_active_head(ring);
        }