netvsc: fix hang on netvsc module removal

The code in netvsc_device_remove was incorrectly calling napi_disable
repeatedly on the same element. This would cause attempts
to remove netvsc module to hang.

Fixes: 2506b1dc4bbe ("netvsc: implement NAPI")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 0e0c757c168101dc7f4d5a0574fb6c90804bf742..8f9aeec2ce0f4f491e838b6f9ac4f194752523ca 100644 (file)
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -562,8 +562,8 @@ void netvsc_device_remove(struct hv_device *device)
        /* Now, we can close the channel safely */
        vmbus_close(device->channel);
 
-       for (i = 0; i < VRSS_CHANNEL_MAX; i++)
-               napi_disable(&net_device->chan_table[0].napi);
+       for (i = 0; i < net_device->num_chn; i++)
+               napi_disable(&net_device->chan_table[i].napi);
 
        /* Release all resources */
        free_netvsc_device(net_device);