udf: fix udf_load_pvoldesc()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 20 May 2015 08:13:15 +0000 (11:13 +0300)
committerJan Kara <jack@suse.cz>
Thu, 21 May 2015 13:19:15 +0000 (15:19 +0200)
There are some missing braces here which means this function never
succeeds.

Fixes: e9d4cf411f75 ('udf: improve error management in udf_CS0toUTF8()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/super.c

index c6a8f5f794439107ddad9ed4e639449a62586fe5..b96f190bc5679bfcc4740d770034352e0c956296 100644 (file)
@@ -937,12 +937,13 @@ static int udf_load_pvoldesc(struct super_block *sb, sector_t block)
                udf_debug("volIdent[] = '%s'\n", UDF_SB(sb)->s_volume_ident);
        }
 
-       if (!udf_build_ustr(instr, pvoldesc->volSetIdent, 128))
+       if (!udf_build_ustr(instr, pvoldesc->volSetIdent, 128)) {
                ret = udf_CS0toUTF8(outstr, instr);
                if (ret < 0)
                        goto out_bh;
 
                udf_debug("volSetIdent[] = '%s'\n", outstr->u_name);
+       }
 
        ret = 0;
 out_bh: