Staging: sep: fix time handler
authorAlan Cox <alan@linux.intel.com>
Fri, 7 Aug 2009 18:24:00 +0000 (19:24 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 15 Sep 2009 19:02:13 +0000 (12:02 -0700)
Cleaning up the code reveals an obvious thinko

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/sep/sep_driver.c

index fe46c1b4647275aec9dc5f96351e0431ac294e11..c2d9cab85d420dc9f081775eb43b35662d8e9f12 100644 (file)
@@ -2143,7 +2143,9 @@ static int sep_get_time_handler(unsigned long arg)
        struct sep_driver_get_time_t command_args;
 
        error = sep_set_time(&command_args.time_physical_address, &command_args.time_value);
-       error = copy_to_user((void *) arg, (void *) &command_args, sizeof(struct sep_driver_get_time_t));
+       if (error == 0)
+               error = copy_to_user((void __user *)arg,
+                       &command_args, sizeof(struct sep_driver_get_time_t));
        return error;
 
 }