qla2xxx: fix kernel NULL pointer access
authorHimanshu Madhani <himanshu.madhani@qlogic.com>
Thu, 25 Sep 2014 10:14:44 +0000 (06:14 -0400)
committerChristoph Hellwig <hch@lst.de>
Thu, 25 Sep 2014 12:25:06 +0000 (14:25 +0200)
This patch is to fix regression added by commit id
51a07f84649d2be206c4c2ad9a612956db0c2f8c.

When allocating memory for new session original patch does
not assign vha to op->vha resulting into NULL pointer
access during qlt_create_sess_from_atio().

Cc: <stable@vger.kernel.org>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/qla2xxx/qla_target.c

index aebe62c9246d779d3b5fa272d2533e08bf4f30a3..43f91778371bd06e3661209f10f66bb90ec53714 100644 (file)
@@ -3277,6 +3277,7 @@ static int qlt_handle_cmd_for_atio(struct scsi_qla_host *vha,
                        return -ENOMEM;
 
                memcpy(&op->atio, atio, sizeof(*atio));
+               op->vha = vha;
                INIT_WORK(&op->work, qlt_create_sess_from_atio);
                queue_work(qla_tgt_wq, &op->work);
                return 0;