[IPV6] tcp_v6_send_synack: release the destination
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 1 Feb 2006 01:51:44 +0000 (17:51 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Feb 2006 01:51:44 +0000 (17:51 -0800)
This patch fix dst reference counting in tcp_v6_send_synack

Analysis:
Currently tcp_v6_send_synack is never called with a dst entry
so dst always comes in as NULL.

ip6_dst_lookup calls ip6_route_output which calls dst_hold
before it returns the dst entry.   Neither xfrm_lookup
nor tcp_make_synack consume the dst entry so we still have
a dst_entry with a bumped refrence count at the end of
this function.

Therefore we need to call dst_release just before we return
just like tcp_v4_send_synack does.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/tcp_ipv6.c

index 66d04004afdaec2a731d953752fb970f17121112..ca9cf6853755fc3081693334c6f8f3e70265dcac 100644 (file)
@@ -515,6 +515,7 @@ static int tcp_v6_send_synack(struct sock *sk, struct request_sock *req,
 done:
         if (opt && opt != np->opt)
                sock_kfree_s(sk, opt, opt->tot_len);
+       dst_release(dst);
        return err;
 }