Bluetooth: hci_uart: check the return value of recv()
authorJiejing Zhang <kzjeef@gmail.com>
Thu, 7 Apr 2011 12:37:06 +0000 (20:37 +0800)
committerGustavo F. Padovan <padovan@profusion.mobi>
Wed, 13 Apr 2011 15:20:03 +0000 (12:20 -0300)
Check the return value of hu->proto->recv() in hci_uart_tty_receive()
the recv() may return error, check it, not add this to statistics.

Signed-off-by: Jiejing Zhang <jiejing.zhang@freescale.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
drivers/bluetooth/hci_ath.c
drivers/bluetooth/hci_ldisc.c

index bd34406faaae087f30eff8bc34b19a7ffb0204d9..4093935ddf42619e44fef9b87428c34454104fe8 100644 (file)
@@ -201,8 +201,13 @@ static struct sk_buff *ath_dequeue(struct hci_uart *hu)
 /* Recv data */
 static int ath_recv(struct hci_uart *hu, void *data, int count)
 {
-       if (hci_recv_stream_fragment(hu->hdev, data, count) < 0)
+       int ret;
+
+       ret = hci_recv_stream_fragment(hu->hdev, data, count);
+       if (ret < 0) {
                BT_ERR("Frame Reassembly Failed");
+               return ret;
+       }
 
        return count;
 }
index 48ad2a7ab080ba9a58c425da7cc959dba0e1e3de..320f71803a2b397f75c77a930dac1bd8de8f496d 100644 (file)
@@ -359,6 +359,7 @@ static void hci_uart_tty_wakeup(struct tty_struct *tty)
  */
 static void hci_uart_tty_receive(struct tty_struct *tty, const u8 *data, char *flags, int count)
 {
+       int ret;
        struct hci_uart *hu = (void *)tty->disc_data;
 
        if (!hu || tty != hu->tty)
@@ -368,8 +369,9 @@ static void hci_uart_tty_receive(struct tty_struct *tty, const u8 *data, char *f
                return;
 
        spin_lock(&hu->rx_lock);
-       hu->proto->recv(hu, (void *) data, count);
-       hu->hdev->stat.byte_rx += count;
+       ret = hu->proto->recv(hu, (void *) data, count);
+       if (ret > 0)
+               hu->hdev->stat.byte_rx += count;
        spin_unlock(&hu->rx_lock);
 
        tty_unthrottle(tty);