net: Copy inner L3 and L4 headers as unaligned on GRE TEB
authorAlexander Duyck <aduyck@mirantis.com>
Tue, 9 Feb 2016 14:14:43 +0000 (06:14 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Feb 2016 20:25:01 +0000 (15:25 -0500)
This patch corrects the unaligned accesses seen on GRE TEB tunnels when
generating hash keys.  Specifically what this patch does is make it so that
we force the use of skb_copy_bits when the GRE inner headers will be
unaligned due to NET_IP_ALIGNED being a non-zero value.

Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Acked-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/flow_dissector.c

index eab81bc80e5cdff993a030b109cbffa133262bf0..12e7003320107dbb2b86f4fa1cfd20a8d59e8ed5 100644 (file)
@@ -399,6 +399,13 @@ ip_proto_again:
                                goto out_bad;
                        proto = eth->h_proto;
                        nhoff += sizeof(*eth);
+
+                       /* Cap headers that we access via pointers at the
+                        * end of the Ethernet header as our maximum alignment
+                        * at that point is only 2 bytes.
+                        */
+                       if (NET_IP_ALIGN)
+                               hlen = nhoff;
                }
 
                key_control->flags |= FLOW_DIS_ENCAPSULATION;