staging: ccree: fix ifnullfree.cocci warnings

drivers/staging/ccree/ssi_hash.c:317:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:320:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:323:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:373:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:375:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:377:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:379:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:381:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:383:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c
index ab191de39fb2b43e0fc64ba822db1b88b75238d0..8ff5d4ec9e5c00d25a81e5a3f2ec47a20b1c5804 100644 (file)
--- a/drivers/staging/ccree/ssi_hash.c
+++ b/drivers/staging/ccree/ssi_hash.c
@@ -314,14 +314,11 @@ fail4:
                state->digest_buff_dma_addr = 0;
        }
 fail3:
-       if (state->opad_digest_buff != NULL)
-               kfree(state->opad_digest_buff);
+       kfree(state->opad_digest_buff);
 fail2:
-       if (state->digest_bytes_len != NULL)
-               kfree(state->digest_bytes_len);
+       kfree(state->digest_bytes_len);
 fail1:
-       if (state->digest_buff != NULL)
-               kfree(state->digest_buff);
+        kfree(state->digest_buff);
 fail_digest_result_buff:
         if (state->digest_result_buff != NULL) {
                 kfree(state->digest_result_buff);
@@ -370,18 +367,12 @@ static void ssi_hash_unmap_request(struct device *dev,
                state->opad_digest_dma_addr = 0;
        }
 
-       if (state->opad_digest_buff != NULL)
-               kfree(state->opad_digest_buff);
-       if (state->digest_bytes_len != NULL)
-               kfree(state->digest_bytes_len);
-       if (state->digest_buff != NULL)
-               kfree(state->digest_buff);
-       if (state->digest_result_buff != NULL) 
-               kfree(state->digest_result_buff);
-       if (state->buff1 != NULL) 
-               kfree(state->buff1);
-       if (state->buff0 != NULL)
-               kfree(state->buff0);
+       kfree(state->opad_digest_buff);
+       kfree(state->digest_bytes_len);
+       kfree(state->digest_buff);
+       kfree(state->digest_result_buff);
+       kfree(state->buff1);
+       kfree(state->buff0);
 }
 
 static void ssi_hash_unmap_result(struct device *dev,