Fix code inspection issues
authorMatthias Schmidt <gravatronics@live.com>
Sun, 14 Oct 2018 12:49:13 +0000 (14:49 +0200)
committerMatthias Schmidt <gravatronics@live.com>
Sun, 14 Oct 2018 12:49:13 +0000 (14:49 +0200)
See #2545

wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationDispatcher.class.php
wcfsetup/install/files/lib/system/devtools/pip/TMultiXmlGuiPackageInstallationPlugin.class.php
wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php
wcfsetup/install/files/lib/system/package/plugin/SmileyPackageInstallationPlugin.class.php
wcfsetup/install/files/lib/system/package/plugin/UserNotificationEventPackageInstallationPlugin.class.php
wcfsetup/install/files/lib/system/package/plugin/UserProfileMenuPackageInstallationPlugin.class.php

index c06ab37658fb544453d6ef3b558c00ff6ce9ba1f..61dfcb84bedc5bc3a476f44b7cae8aa1a1db2c8e 100644 (file)
@@ -2,7 +2,6 @@
 namespace wcf\system\devtools\pip;
 use wcf\data\devtools\project\DevtoolsProject;
 use wcf\system\devtools\package\DevtoolsInstaller;
-use wcf\system\devtools\package\DevtoolsPackageArchive;
 use wcf\system\package\PackageInstallationDispatcher;
 
 /**
index 4c9a42142b0f13a1d1d2435b3b858912f20a0187..f324e967a391ee8c0d3ace931416e8045f34a74e 100644 (file)
@@ -2,6 +2,7 @@
 namespace wcf\system\devtools\pip;
 use wcf\system\form\builder\field\IFormField;
 use wcf\system\form\builder\IFormDocument;
+use wcf\system\form\builder\IFormNode;
 use wcf\system\package\PackageInstallationDispatcher;
 use wcf\util\DOMUtil;
 use wcf\util\XML;
@@ -153,7 +154,8 @@ trait TMultiXmlGuiPackageInstallationPlugin {
                        
                        $data = $this->getElementData($element);
                        
-                       /** @var IFormNode $node */
+                       /** @var IFormNode $node
+                        */
                        foreach ($document->getIterator() as $node) {
                                if ($node instanceof IFormField && $node->isAvailable()) {
                                        $key = $node->getId();
index e422ea05ffb86b01e321dfd44f66e49fd0a4d519..5526b8499957985d28b1becb785a234d4a5e9f44 100644 (file)
@@ -613,7 +613,7 @@ class LanguagePackageInstallationPlugin extends AbstractXMLPackageInstallationPl
         * @return      string
         */
        protected function getEmptyXml($languageCode) {
-               $xsdFilename = $this->getXsdFilenlangame();
+               $xsdFilename = $this->getXsdFilename();
                
                $language = LanguageFactory::getInstance()->getLanguageByCode($languageCode);
                if ($language === null) {
index 3d8605cb4d02f5bf8e0f8d56e11c004079530751..551c0210f750b4f4c294266454bce6d5cee5c7e7 100644 (file)
@@ -5,6 +5,7 @@ use wcf\data\smiley\SmileyList;
 use wcf\system\devtools\pip\IDevtoolsPipEntryList;
 use wcf\system\devtools\pip\IGuiPackageInstallationPlugin;
 use wcf\system\devtools\pip\TXmlGuiPackageInstallationPlugin;
+use wcf\system\form\builder\container\FormContainer;
 use wcf\system\form\builder\field\IntegerFormField;
 use wcf\system\form\builder\field\ItemListFormField;
 use wcf\system\form\builder\field\TextFormField;
index 3455c4049ad66d3cead33e6747b3c30a76031638..052d636df564ed138c5095613c8e4fc15d0963ce 100644 (file)
@@ -15,7 +15,6 @@ use wcf\system\form\builder\field\validation\FormFieldValidationError;
 use wcf\system\form\builder\field\validation\FormFieldValidator;
 use wcf\system\form\builder\field\BooleanFormField;
 use wcf\system\form\builder\field\ClassNameFormField;
-use wcf\system\form\builder\field\ItemListFormField;
 use wcf\system\form\builder\field\SingleSelectionFormField;
 use wcf\system\form\builder\field\TextFormField;
 use wcf\system\form\builder\IFormDocument;
index fceba3f7cc6868055edcabb89c1a83f436aabd58..d6e6aab1c25f0af42c330551286d126fc1be2c8d 100644 (file)
@@ -12,7 +12,6 @@ use wcf\system\form\builder\field\validation\FormFieldValidationError;
 use wcf\system\form\builder\field\validation\FormFieldValidator;
 use wcf\system\form\builder\field\ClassNameFormField;
 use wcf\system\form\builder\field\IntegerFormField;
-use wcf\system\form\builder\field\ItemListFormField;
 use wcf\system\form\builder\field\TextFormField;
 use wcf\system\form\builder\IFormDocument;
 use wcf\system\menu\user\profile\content\IUserProfileMenuContent;