Bluetooth: Move HCI_ADVERTISING handling into mgmt.c
authorJohan Hedberg <johan.hedberg@intel.com>
Mon, 24 Feb 2014 12:52:17 +0000 (14:52 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 24 Feb 2014 19:10:36 +0000 (11:10 -0800)
We'll soon need to make decisions on toggling the HCI_ADVERTISING flag
based on pending mgmt_set_powered commands. Therefore, move the handling
from hci_event.c into mgmt.c.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
include/net/bluetooth/hci_core.h
net/bluetooth/hci_event.c
net/bluetooth/mgmt.c

index d2d75675371442eaf56d3ecbee5f5f1e7a85d0fc..6ff882e727d4be64e2c2c894d6c51c8041c08a97 100644 (file)
@@ -1174,6 +1174,7 @@ int mgmt_powered(struct hci_dev *hdev, u8 powered);
 void mgmt_discoverable_timeout(struct hci_dev *hdev);
 void mgmt_discoverable(struct hci_dev *hdev, u8 discoverable);
 void mgmt_connectable(struct hci_dev *hdev, u8 connectable);
+void mgmt_advertising(struct hci_dev *hdev, u8 advertising);
 void mgmt_write_scan_failed(struct hci_dev *hdev, u8 scan, u8 status);
 void mgmt_new_link_key(struct hci_dev *hdev, struct link_key *key,
                       bool persistent);
index 064d619344b358b097087ae80dd1ba7b59478d45..dea465ba276b1a505839bae2686de93631501b2f 100644 (file)
@@ -991,12 +991,8 @@ static void hci_cc_le_set_adv_enable(struct hci_dev *hdev, struct sk_buff *skb)
 
        hci_dev_lock(hdev);
 
-       if (!status) {
-               if (*sent)
-                       set_bit(HCI_ADVERTISING, &hdev->dev_flags);
-               else
-                       clear_bit(HCI_ADVERTISING, &hdev->dev_flags);
-       }
+       if (!status)
+               mgmt_advertising(hdev, *sent);
 
        hci_dev_unlock(hdev);
 }
index 9865e523df20437e33be140e007727c8a60e100d..d39e57e9fed6f182275d54ddb541817e9148d35d 100644 (file)
@@ -4832,6 +4832,14 @@ void mgmt_connectable(struct hci_dev *hdev, u8 connectable)
                new_settings(hdev, NULL);
 }
 
+void mgmt_advertising(struct hci_dev *hdev, u8 advertising)
+{
+       if (advertising)
+               set_bit(HCI_ADVERTISING, &hdev->dev_flags);
+       else
+               clear_bit(HCI_ADVERTISING, &hdev->dev_flags);
+}
+
 void mgmt_write_scan_failed(struct hci_dev *hdev, u8 scan, u8 status)
 {
        u8 mgmt_err = mgmt_status(status);