ASoC: mxs-saif: remove function in platform_data

Add master_mode and master_id in platfrom_data since it's board
specific and board knows it.
Then we can remove the function pointer in platfrom_data to make
the driver more devicetree friendly.

Signed-off-by: Dong Aisheng <b29396@freescale.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

diff --git a/include/sound/saif.h b/include/sound/saif.h
index d0e0de7984ecb300b160bd6523e70a566d14636f..f22f3e16edf46d082b49849116001f65be8fde73 100644 (file)
--- a/include/sound/saif.h
+++ b/include/sound/saif.h
@@ -10,7 +10,7 @@
 #define __SOUND_SAIF_H__
 
 struct mxs_saif_platform_data {
-       int (*init) (void);
-       int (*get_master_id) (unsigned int saif_id);
+       bool master_mode;       /* if true use master mode */
+       int master_id;          /* id of the master if in slave mode */
 };
 #endif

diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index 76dc74d24fc2ff7b50b9665b7443c56372c70b7c..1ef697fe17317a6860bddf14982841440bdeb87c 100644 (file)
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -625,13 +625,6 @@ static int mxs_saif_probe(struct platform_device *pdev)
        if (pdev->id >= ARRAY_SIZE(mxs_saif))
                return -EINVAL;
 
-       pdata = pdev->dev.platform_data;
-       if (pdata && pdata->init) {
-               ret = pdata->init();
-               if (ret)
-                       return ret;
-       }
-
        saif = kzalloc(sizeof(*saif), GFP_KERNEL);
        if (!saif)
                return -ENOMEM;
@@ -639,12 +632,17 @@ static int mxs_saif_probe(struct platform_device *pdev)
        mxs_saif[pdev->id] = saif;
        saif->id = pdev->id;
 
-       saif->master_id = saif->id;
-       if (pdata && pdata->get_master_id) {
-               saif->master_id = pdata->get_master_id(saif->id);
+       pdata = pdev->dev.platform_data;
+       if (pdata && !pdata->master_mode) {
+               saif->master_id = pdata->master_id;
                if (saif->master_id < 0 ||
-                       saif->master_id >= ARRAY_SIZE(mxs_saif))
+                       saif->master_id >= ARRAY_SIZE(mxs_saif) ||
+                       saif->master_id == saif->id) {
+                       dev_err(&pdev->dev, "get wrong master id\n");
                        return -EINVAL;
+               }
+       } else {
+               saif->master_id = saif->id;
        }
 
        saif->clk = clk_get(&pdev->dev, NULL);