sunvnet: vnet_ack() should check if !start_cons to send a missed trigger
authorSowmini Varadhan <sowmini.varadhan@oracle.com>
Sun, 9 Nov 2014 01:42:10 +0000 (20:42 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 11 Nov 2014 02:05:36 +0000 (21:05 -0500)
As per comments in vnet_start_xmit, for the edge case
when outgoing vnet_start_xmit() data and an incoming STOPPED
ACK cross each other in flight, we may need to send the missed
START trigger from maybe_tx_wakeup() after checking for a
false value of start_cons

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/sunvnet.c

index deb395a82e50b7f2a477a83214328482ae121e91..826b3852c7df969d130635ff19331618799dcf18 100644 (file)
@@ -572,7 +572,7 @@ static int vnet_ack(struct vnet_port *port, void *msgbuf)
         */
        dr->cons = next_idx(end, dr);
        desc = vio_dring_entry(dr, dr->cons);
-       if (desc->hdr.state == VIO_DESC_READY && port->start_cons) {
+       if (desc->hdr.state == VIO_DESC_READY && !port->start_cons) {
                /* vnet_start_xmit() just populated this dring but missed
                 * sending the "start" LDC message to the consumer.
                 * Send a "start" trigger on its behalf.