sfc: Remove write permission from phy_type attribute
authorBen Hutchings <bhutchings@solarflare.com>
Tue, 18 Jun 2013 16:45:40 +0000 (17:45 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Jun 2013 05:18:52 +0000 (22:18 -0700)
Driver probe currently results in:

WARNING: at drivers/base/core.c:576 device_create_file+0x57/0x7e()
Attribute phy_type: write permission without 'store'

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/efx.c

index 39e4cb39de29493d30079f3ddcfc81e46cfbf5b4..4a14a940c65e70f052a83bd7384722a4dbe4e768 100644 (file)
@@ -2139,7 +2139,7 @@ show_phy_type(struct device *dev, struct device_attribute *attr, char *buf)
        struct efx_nic *efx = pci_get_drvdata(to_pci_dev(dev));
        return sprintf(buf, "%d\n", efx->phy_type);
 }
-static DEVICE_ATTR(phy_type, 0644, show_phy_type, NULL);
+static DEVICE_ATTR(phy_type, 0444, show_phy_type, NULL);
 
 static int efx_register_netdev(struct efx_nic *efx)
 {