net: rtnl: info leak in rtnl_fill_vfinfo()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 13 Oct 2016 08:45:28 +0000 (11:45 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Oct 2016 16:12:04 +0000 (12:12 -0400)
The "vf_vlan_info" struct ends with a 2 byte struct hole so we have to
memset it to ensure that no stack information is revealed to user space.

Fixes: 79aab093a0b5 ('net: Update API for VF vlan protocol 802.1ad support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c

index b06d2f46b83e98c4fb6a92cefd625c2918eafdeb..fb7348f135014fcea21b621ab30e1ad02b62448d 100644 (file)
@@ -1144,6 +1144,8 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,
        if (dev->netdev_ops->ndo_get_vf_config(dev, vfs_num, &ivi))
                return 0;
 
+       memset(&vf_vlan_info, 0, sizeof(vf_vlan_info));
+
        vf_mac.vf =
                vf_vlan.vf =
                vf_vlan_info.vf =