[PATCH] bcm43xx: Fix deviation from specifications in set_baseband_attenuation
authorLarry Finger <Larry.Finger@lwfinger.net>
Sun, 27 May 2007 03:21:29 +0000 (22:21 -0500)
committerJeff Garzik <jeff@garzik.org>
Mon, 9 Jul 2007 02:16:37 +0000 (22:16 -0400)
A disagreement between the specifications and the bcm43xx code has just
been discovered and is hereby fixed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/bcm43xx/bcm43xx_phy.c

index b37f1e348700c9c775dce61695bd2bde12101b6e..d779199c30d056d707ea341530ce453472f09bc2 100644 (file)
@@ -1638,7 +1638,7 @@ void bcm43xx_phy_set_baseband_attenuation(struct bcm43xx_private *bcm,
                return;
        }
 
-       if (phy->analog > 1) {
+       if (phy->analog == 1) {
                value = bcm43xx_phy_read(bcm, 0x0060) & ~0x003C;
                value |= (baseband_attenuation << 2) & 0x003C;
        } else {