perf_counter: allow and require one-page mmap on counting counters
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Wed, 25 Mar 2009 11:48:31 +0000 (12:48 +0100)
committerIngo Molnar <mingo@elte.hu>
Mon, 6 Apr 2009 07:30:35 +0000 (09:30 +0200)
A brainfart stopped single page mmap()s working. The rest of the code
should be perfectly fine with not having any data pages.

Reported-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Orig-LKML-Reference: <1237981712.7972.812.camel@twins>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/perf_counter.c

index f3e1b27bc1b8559126bea89d6f701bfd4061ac61..95e02575546b0559135c336ae6dbbf448a7a0726 100644 (file)
@@ -1369,7 +1369,11 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma)
        vma_size = vma->vm_end - vma->vm_start;
        nr_pages = (vma_size / PAGE_SIZE) - 1;
 
-       if (nr_pages == 0 || !is_power_of_2(nr_pages))
+       /*
+        * If we have data pages ensure they're a power-of-two number, so we
+        * can do bitmasks instead of modulo.
+        */
+       if (nr_pages != 0 && !is_power_of_2(nr_pages))
                return -EINVAL;
 
        if (vma_size != PAGE_SIZE * (1 + nr_pages))