ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 30 Jun 2017 22:34:23 +0000 (17:34 -0500)
committerTakashi Iwai <tiwai@suse.de>
Sat, 1 Jul 2017 06:03:34 +0000 (08:03 +0200)
platform_get_irq() returns an error code, but the ac97c
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.

Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/atmel/ac97c.c

index 65e6948e3995ddbfdfca085c87c9496b9d9621b6..9d2c9d9af688030d660b63badbefc3f88e553aa2 100644 (file)
@@ -774,8 +774,8 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0) {
-               dev_dbg(&pdev->dev, "could not get irq\n");
-               return -ENXIO;
+               dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
+               return irq;
        }
 
        pclk = clk_get(&pdev->dev, "ac97_clk");