drivers:misc: ti-st: free skb on firmware download
authorPavan Savoy <pavan_savoy@ti.com>
Wed, 10 Aug 2011 15:18:36 +0000 (10:18 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 22 Aug 2011 21:13:34 +0000 (14:13 -0700)
If during validation of the firmware download the data doesn't match what is
expected out of the chip, this calls for a firmware download failure and a
retry.
Free the SKB which collects response during such scenarios.

Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/misc/ti-st/st_kim.c

index d8ca4068a928d241f100e95a9d71e81b6d7d5b5c..3a3580566dfca39fa5e2882f1658418665a9e72d 100644 (file)
@@ -68,6 +68,7 @@ void validate_firmware_response(struct kim_data_s *kim_gdata)
        if (unlikely(skb->data[5] != 0)) {
                pr_err("no proper response during fw download");
                pr_err("data6 %x", skb->data[5]);
+               kfree_skb(skb);
                return;         /* keep waiting for the proper response */
        }
        /* becos of all the script being downloaded */