tuntap: reset network header before calling skb_get_rxhash()
authorEric Dumazet <edumazet@google.com>
Mon, 17 Dec 2012 04:39:20 +0000 (04:39 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Dec 2012 20:32:44 +0000 (12:32 -0800)
Commit 499744209b2c (tuntap: dont use skb after netif_rx_ni(skb))
introduced another bug.

skb_get_rxhash() needs to access the network header, and it was
set for us in netif_rx_ni().

We need to reset network header or else skb_flow_dissect() behavior
is out of control.

Reported-and-tested-by: Kirill A. Shutemov <kirill@shutemov.name>
Tested-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c

index 255a9f574869fd6d4fc09a0cf3f9a80ca7c1d7fd..173acf5b369ade70d6c3ce0da86999e04cfe61ee 100644 (file)
@@ -1199,6 +1199,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
                skb_shinfo(skb)->tx_flags |= SKBTX_DEV_ZEROCOPY;
        }
 
+       skb_reset_network_header(skb);
        rxhash = skb_get_rxhash(skb);
        netif_rx_ni(skb);