staging/rdma/hfi1: cleanup messages on qsfp_read() failure
authorEaswar Hariharan <easwar.hariharan@intel.com>
Wed, 3 Feb 2016 22:30:57 +0000 (14:30 -0800)
committerDoug Ledford <dledford@redhat.com>
Fri, 11 Mar 2016 01:37:46 +0000 (20:37 -0500)
The ":" in "%s:" adds no value.

Reviewed-by: Dean Luick <dean.luick@intel.com>
Signed-off-by: Easwar Hariharan <easwar.hariharan@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/staging/rdma/hfi1/qsfp.c

index 6326a915d7fd30ed4ae92bd4c51569fc16f360af..6e9c56fe27e768a14b4c705ddcf950a9c0716c9e 100644 (file)
@@ -330,48 +330,48 @@ int refresh_qsfp_cache(struct hfi1_pportdata *ppd, struct qsfp_data *cp)
                        /* all */
                        ret = qsfp_read(ppd, target, 384, cache + 256, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                        ret = qsfp_read(ppd, target, 640, cache + 384, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                        ret = qsfp_read(ppd, target, 896, cache + 512, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                } else if ((cache[195] & 0x80) == 0x80) {
                        /* only page 2 and 3 */
                        ret = qsfp_read(ppd, target, 640, cache + 384, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                        ret = qsfp_read(ppd, target, 896, cache + 512, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                } else if ((cache[195] & 0x40) == 0x40) {
                        /* only page 1 and 3 */
                        ret = qsfp_read(ppd, target, 384, cache + 256, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                        ret = qsfp_read(ppd, target, 896, cache + 512, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                } else {
                        /* only page 3 */
                        ret = qsfp_read(ppd, target, 896, cache + 512, 128);
                        if (ret <= 0 || ret != 128) {
-                               dd_dev_info(ppd->dd, "%s: failed\n", __func__);
+                               dd_dev_info(ppd->dd, "%s failed\n", __func__);
                                goto bail;
                        }
                }