tipc: remove unnecessary checking for node object
authorYing Xue <ying.xue@windriver.com>
Thu, 27 Mar 2014 04:54:30 +0000 (12:54 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Mar 2014 17:08:36 +0000 (13:08 -0400)
tipc_node_create routine doesn't need to check whether a node
object specified with a node address exists or not because its
caller(ie, tipc_disc_recv_msg routine) has checked this before
calling it.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/node.c

index 0b0f6c7da965921948523fa1dae4ecb0b67f9569..7c9b6673e2ab9161757dd31f647314b887241410 100644 (file)
@@ -95,12 +95,6 @@ struct tipc_node *tipc_node_create(u32 addr)
 
        spin_lock_bh(&node_create_lock);
 
-       n_ptr = tipc_node_find(addr);
-       if (n_ptr) {
-               spin_unlock_bh(&node_create_lock);
-               return n_ptr;
-       }
-
        n_ptr = kzalloc(sizeof(*n_ptr), GFP_ATOMIC);
        if (!n_ptr) {
                spin_unlock_bh(&node_create_lock);