pinctrl: Adjust five checks for null pointers
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 2 May 2017 08:01:57 +0000 (10:01 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 22 May 2017 08:39:24 +0000 (10:39 +0200)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinconf.c

index 44471f6b98988a64b2293ffe70f8483643b3872a..2f4bcb6b3844a0a34181118fe117b7b03adeaba7 100644 (file)
@@ -319,7 +319,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
                pin = pctldev->desc->pins[i].number;
                desc = pin_desc_get(pctldev, pin);
                /* Skip if we cannot search the pin */
-               if (desc == NULL)
+               if (!desc)
                        continue;
 
                seq_printf(s, "pin %d (%s): ", pin, desc->name);
@@ -524,7 +524,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
 
        /* get arg 'device_name' */
        token = strsep(&b, " ");
-       if (token == NULL)
+       if (!token)
                return -EINVAL;
        if (strlen(token) >= MAX_NAME_LEN)
                return -EINVAL;
@@ -532,7 +532,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
 
        /* get arg 'state_name' */
        token = strsep(&b, " ");
-       if (token == NULL)
+       if (!token)
                return -EINVAL;
        if (strlen(token) >= MAX_NAME_LEN)
                return -EINVAL;
@@ -540,7 +540,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
 
        /* get arg 'pin_name' */
        token = strsep(&b, " ");
-       if (token == NULL)
+       if (!token)
                return -EINVAL;
        if (strlen(token) >= MAX_NAME_LEN)
                return -EINVAL;
@@ -548,7 +548,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
 
        /* get new_value of config' */
        token = strsep(&b, " ");
-       if (token == NULL)
+       if (!token)
                return -EINVAL;
        if (strlen(token) >= MAX_NAME_LEN)
                return -EINVAL;