drm/vc4: Fix memory leak of the CRTC state.
authorEric Anholt <eric@anholt.net>
Mon, 10 Oct 2016 16:44:06 +0000 (09:44 -0700)
committerEric Anholt <eric@anholt.net>
Tue, 17 Jan 2017 10:12:39 +0000 (21:12 +1100)
The underscores variant frees the pointers inside, while the
no-underscores variant calls underscores and then frees the struct.

Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: d8dbf44f13b9 ("drm/vc4: Make the CRTCs cooperate on allocating display lists.")
Cc: stable@vger.kernel.org
drivers/gpu/drm/vc4/vc4_crtc.c

index a0fd3e66bc4b39c1f5092c340ad2c705bbf431f3..7aadce1f7e7a0e56b302bded53ad8c0d5977cc22 100644 (file)
@@ -839,7 +839,7 @@ static void vc4_crtc_destroy_state(struct drm_crtc *crtc,
 
        }
 
-       __drm_atomic_helper_crtc_destroy_state(state);
+       drm_atomic_helper_crtc_destroy_state(crtc, state);
 }
 
 static const struct drm_crtc_funcs vc4_crtc_funcs = {