usb: xhci: fix wild pointers in xhci_mem_cleanup
authorLu Baolu <baolu.lu@linux.intel.com>
Fri, 8 Apr 2016 13:25:09 +0000 (16:25 +0300)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:12:51 +0000 (13:12 +0000)
commit 71504062a7c34838c3fccd92c447f399d3cb5797 upstream.

This patch fixes some wild pointers produced by xhci_mem_cleanup.
These wild pointers will cause system crash if xhci_mem_cleanup()
is called twice.

Reported-and-tested-by: Pengcheng Li <lpc.li@hisilicon.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[wt: struct xhci_hcd has no ext_caps members in 3.10 ]

Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/usb/host/xhci-mem.c

index a9249dd90d55937dae290ce22b7ac58db96724c9..1c3a5ee86e437da9f0d88dd15e067c3065f44766 100644 (file)
@@ -1872,6 +1872,11 @@ no_bw:
        kfree(xhci->port_array);
        kfree(xhci->rh_bw);
 
+       xhci->usb2_ports = NULL;
+       xhci->usb3_ports = NULL;
+       xhci->port_array = NULL;
+       xhci->rh_bw = NULL;
+
        xhci->page_size = 0;
        xhci->page_shift = 0;
        xhci->bus_state[0].bus_suspended = 0;