Fix warning on uninitialized buftype
authorSteve French <smfrench@gmail.com>
Wed, 25 Mar 2015 23:51:57 +0000 (18:51 -0500)
committerSteve French <smfrench@gmail.com>
Wed, 1 Apr 2015 05:01:46 +0000 (00:01 -0500)
Pointed out by coverity analyzer.  resp_buftype is
not initialized in one path which can rarely log
a spurious warning (buf is null so there will
not be a problem with freeing data, but if buf_type
were randomly set to wrong value could log a warning)

Reported by Coverity (CID 1269144)

Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
fs/cifs/smb2pdu.c

index 3417340bf89e677fe0c46bf98cf922dd39d29a3a..1b906debe11d375d512350f769d1ceeabfeecf96 100644 (file)
@@ -2114,7 +2114,7 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon,
        struct kvec iov[2];
        int rc = 0;
        int len;
-       int resp_buftype;
+       int resp_buftype = CIFS_NO_BUFFER;
        unsigned char *bufptr;
        struct TCP_Server_Info *server;
        struct cifs_ses *ses = tcon->ses;