[PATCH] uml: stack usage reduction

The KSTK_* macros used an inordinate amount of stack.  In order to overcome
an impedance mismatch between their interface, which just returns a single
register value, and the interface of get_thread_regs, which took a full
pt_regs, the implementation created an on-stack pt_regs, filled it in, and
returned one field.  do_task_stat calls KSTK_* twice, resulting in two
local pt_regs, blowing out the stack.

This patch changes the interface (and name) of get_thread_regs to just
return a single register from a jmp_buf.

The include of archsetjmp.h" in registers.h to get the definition of
jmp_buf exposed a bogus include of <setjmp.h> in start_up.c.  <setjmp.h>
shouldn't be used anywhere any more since UML uses the klibc
setjmp/longjmp.

Signed-off-by: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

diff --git a/arch/um/include/registers.h b/arch/um/include/registers.h
index 83b688ca198fb3c0e01f8e8acd2b55a5c50f19c6..f845b3629a6d021b9a0b5f1b9a2ff80f5a80b8d2 100644 (file)
--- a/arch/um/include/registers.h
+++ b/arch/um/include/registers.h
@@ -7,6 +7,7 @@
 #define __REGISTERS_H
 
 #include "sysdep/ptrace.h"
+#include "sysdep/archsetjmp.h"
 
 extern void init_thread_registers(union uml_pt_regs *to);
 extern int save_fp_registers(int pid, unsigned long *fp_regs);
@@ -15,6 +16,6 @@ extern void save_registers(int pid, union uml_pt_regs *regs);
 extern void restore_registers(int pid, union uml_pt_regs *regs);
 extern void init_registers(int pid);
 extern void get_safe_registers(unsigned long * regs, unsigned long * fp_regs);
-extern void get_thread_regs(union uml_pt_regs *uml_regs, void *buffer);
+extern unsigned long get_thread_reg(int reg, jmp_buf *buf);
 
 #endif

diff --git a/arch/um/os-Linux/start_up.c b/arch/um/os-Linux/start_up.c
index 5031485040090bfc07ba71eca0a41564c0cc8b03..7fe92680c7dd8de39fef42309818df27546ff17a 100644 (file)
--- a/arch/um/os-Linux/start_up.c
+++ b/arch/um/os-Linux/start_up.c
@@ -14,7 +14,6 @@
 #include <sched.h>
 #include <fcntl.h>
 #include <errno.h>
-#include <setjmp.h>
 #include <sys/time.h>
 #include <sys/wait.h>
 #include <sys/mman.h>

diff --git a/arch/um/os-Linux/sys-i386/registers.c b/arch/um/os-Linux/sys-i386/registers.c
index 1f90a2d713863156bcb8fbe6262fd8fd3c4386f7..7cd0369e02b3b82970727bec506038ecb3cfd00c 100644 (file)
--- a/arch/um/os-Linux/sys-i386/registers.c
+++ b/arch/um/os-Linux/sys-i386/registers.c
@@ -130,11 +130,14 @@ void get_safe_registers(unsigned long *regs, unsigned long *fp_regs)
                       HOST_FP_SIZE * sizeof(unsigned long));
 }
 
-void get_thread_regs(union uml_pt_regs *uml_regs, void *buffer)
+unsigned long get_thread_reg(int reg, jmp_buf *buf)
 {
-       struct __jmp_buf *jmpbuf = buffer;
-
-       UPT_SET(uml_regs, EIP, jmpbuf->__eip);
-       UPT_SET(uml_regs, UESP, jmpbuf->__esp);
-       UPT_SET(uml_regs, EBP, jmpbuf->__ebp);
+       switch(reg){
+       case EIP: return buf[0]->__eip;
+       case UESP: return buf[0]->__esp;
+       case EBP: return buf[0]->__ebp;
+       default:
+               printk("get_thread_regs - unknown register %d\n", reg);
+               return 0;
+       }
 }

diff --git a/arch/um/os-Linux/sys-x86_64/registers.c b/arch/um/os-Linux/sys-x86_64/registers.c
index e730447d6c026df722ac12ce07c5dcc106ee66ca..cb8e8a2632803c75d1c90db8b0b73cbbc86b6d07 100644 (file)
--- a/arch/um/os-Linux/sys-x86_64/registers.c
+++ b/arch/um/os-Linux/sys-x86_64/registers.c
@@ -78,11 +78,14 @@ void get_safe_registers(unsigned long *regs, unsigned long *fp_regs)
                       HOST_FP_SIZE * sizeof(unsigned long));
 }
 
-void get_thread_regs(union uml_pt_regs *uml_regs, void *buffer)
+unsigned long get_thread_reg(int reg, jmp_buf *buf)
 {
-       struct __jmp_buf *jmpbuf = buffer;
-
-       UPT_SET(uml_regs, RIP, jmpbuf->__rip);
-       UPT_SET(uml_regs, RSP, jmpbuf->__rsp);
-       UPT_SET(uml_regs, RBP, jmpbuf->__rbp);
+       switch(reg){
+       case RIP: return buf[0]->__rip;
+       case RSP: return buf[0]->__rsp;
+       case RBP: return buf[0]->__rbp;
+       default:
+               printk("get_thread_regs - unknown register %d\n", reg);
+               return 0;
+       }
 }

diff --git a/include/asm-um/processor-generic.h b/include/asm-um/processor-generic.h
index 824c2889638215177fb372219df2cf4c968fc61e..afa4fe1ca9f13eaba82ebd9b33df0602e47ca022 100644 (file)
--- a/include/asm-um/processor-generic.h
+++ b/include/asm-um/processor-generic.h
@@ -138,9 +138,7 @@ extern struct cpuinfo_um cpu_data[];
 
 #ifdef CONFIG_MODE_SKAS
 #define KSTK_REG(tsk, reg) \
-       ({ union uml_pt_regs regs; \
-          get_thread_regs(&regs, tsk->thread.mode.skas.switch_buf); \
-          UPT_REG(&regs, reg); })
+       get_thread_reg(reg, tsk->thread.mode.skas.switch_buf)
 #else
 #define KSTK_REG(tsk, reg) (0xbadbabe)
 #endif