IB/qib: fix false-postive maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 14 Mar 2017 12:18:45 +0000 (13:18 +0100)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Nov 2017 09:46:02 +0000 (10:46 +0100)
commit f6aafac184a3e46e919769dd4faa8bf0dc436534 upstream.

aarch64-linux-gcc-7 complains about code it doesn't fully understand:

drivers/infiniband/hw/qib/qib_iba7322.c: In function 'qib_7322_txchk_change':
include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The code is right, and despite trying hard, I could not come up with a version
that I liked better than just adding a fake initialization here to shut up the
warning.

Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/infiniband/hw/qib/qib_iba7322.c

index 5f5f20f4223143478bc014835bdbf9957a25c5cc..c61f3e7aa3538245a0c37f1a0ee901f371cafa36 100644 (file)
@@ -6670,7 +6670,7 @@ static void qib_7322_txchk_change(struct qib_devdata *dd, u32 start,
        unsigned long flags;
 
        while (wait) {
-               unsigned long shadow;
+               unsigned long shadow = 0;
                int cstart, previ = -1;
 
                /*