sh-pfc: Rename gpio arguments to be consistent with the rest of the code
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 15 Jul 2013 11:25:08 +0000 (13:25 +0200)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 29 Jul 2013 13:17:42 +0000 (15:17 +0200)
The gpio_get_data_reg() and gpio_setup_data_reg() functions both take an
argument named gpio. The argument contains a GPIO offset for the first
function and a pin index for the second one. Rename them to offset and
idx respectively to match the rest of the code.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
drivers/pinctrl/sh-pfc/gpio.c

index 3620bd84ae938a5712ee7ad1ab66ac0474061115..87ae38b97a3842a7d9aecbd9ecf958282b9aa424 100644 (file)
@@ -48,11 +48,11 @@ static struct sh_pfc *gpio_to_pfc(struct gpio_chip *gc)
        return gpio_to_pfc_chip(gc)->pfc;
 }
 
-static void gpio_get_data_reg(struct sh_pfc_chip *chip, unsigned int gpio,
+static void gpio_get_data_reg(struct sh_pfc_chip *chip, unsigned int offset,
                              struct sh_pfc_gpio_data_reg **reg,
                              unsigned int *bit)
 {
-       int idx = sh_pfc_get_pin_index(chip->pfc, gpio);
+       int idx = sh_pfc_get_pin_index(chip->pfc, offset);
        struct sh_pfc_gpio_pin *gpio_pin = &chip->pins[idx];
 
        *reg = &chip->regs[gpio_pin->dreg];
@@ -76,11 +76,11 @@ static void gpio_write_data_reg(struct sh_pfc_chip *chip,
        sh_pfc_write_raw_reg(mem, dreg->reg_width, value);
 }
 
-static void gpio_setup_data_reg(struct sh_pfc_chip *chip, unsigned gpio)
+static void gpio_setup_data_reg(struct sh_pfc_chip *chip, unsigned idx)
 {
        struct sh_pfc *pfc = chip->pfc;
-       struct sh_pfc_gpio_pin *gpio_pin = &chip->pins[gpio];
-       const struct sh_pfc_pin *pin = &pfc->info->pins[gpio];
+       struct sh_pfc_gpio_pin *gpio_pin = &chip->pins[idx];
+       const struct sh_pfc_pin *pin = &pfc->info->pins[idx];
        const struct pinmux_data_reg *dreg;
        unsigned int bit;
        unsigned int i;