projects
/
GitHub
/
LineageOS
/
android_kernel_motorola_exynos9610.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4cdd641
)
powerpc/mpc5xxx: delete unneeded test before of_node_put
author
Julia Lawall
<Julia.Lawall@lip6.fr>
Fri, 8 Aug 2014 10:07:46 +0000
(12:07 +0200)
committer
Michael Ellerman
<mpe@ellerman.id.au>
Sun, 9 Nov 2014 22:59:34 +0000
(09:59 +1100)
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/sysdev/mpc5xxx_clocks.c
patch
|
blob
|
blame
|
history
diff --git
a/arch/powerpc/sysdev/mpc5xxx_clocks.c
b/arch/powerpc/sysdev/mpc5xxx_clocks.c
index 5492dc5f56f4672adcff6d10e605aa91cc82bfca..f4f0301b9a60a710cacc2cea98eaef827cffba2b 100644
(file)
--- a/
arch/powerpc/sysdev/mpc5xxx_clocks.c
+++ b/
arch/powerpc/sysdev/mpc5xxx_clocks.c
@@
-26,8
+26,7
@@
unsigned long mpc5xxx_get_bus_frequency(struct device_node *node)
of_node_put(node);
node = np;
}
- if (node)
- of_node_put(node);
+ of_node_put(node);
return p_bus_freq ? *p_bus_freq : 0;
}