perf evlist: Make create_maps() use set_maps()
authorAdrian Hunter <adrian.hunter@intel.com>
Tue, 8 Sep 2015 07:58:57 +0000 (10:58 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 15 Sep 2015 13:45:47 +0000 (10:45 -0300)
Since there is a function to set maps, perf_evlist__create_maps() should
use it.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Link: http://lkml.kernel.org/r/1441699142-18905-10-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/evlist.c

index 78ff52ee878827937b9dcc5ec2f31b85a516a8a1..c17f3558a37a1bea8de4ac8f5d7f1e78fc1efdcc 100644 (file)
@@ -1126,29 +1126,30 @@ static void perf_evlist__propagate_maps(struct perf_evlist *evlist)
 
 int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target)
 {
-       evlist->threads = thread_map__new_str(target->pid, target->tid,
-                                             target->uid);
+       struct cpu_map *cpus;
+       struct thread_map *threads;
 
-       if (evlist->threads == NULL)
+       threads = thread_map__new_str(target->pid, target->tid, target->uid);
+
+       if (!threads)
                return -1;
 
        if (target__uses_dummy_map(target))
-               evlist->cpus = cpu_map__dummy_new();
+               cpus = cpu_map__dummy_new();
        else
-               evlist->cpus = cpu_map__new(target->cpu_list);
+               cpus = cpu_map__new(target->cpu_list);
 
-       if (evlist->cpus == NULL)
+       if (!cpus)
                goto out_delete_threads;
 
        evlist->has_user_cpus = !!target->cpu_list;
 
-       perf_evlist__propagate_maps(evlist);
+       perf_evlist__set_maps(evlist, cpus, threads);
 
        return 0;
 
 out_delete_threads:
-       thread_map__put(evlist->threads);
-       evlist->threads = NULL;
+       thread_map__put(threads);
        return -1;
 }