staging: dgap: check unchecked return values
authorMark Hounschell <markh@compro.net>
Fri, 25 Apr 2014 17:10:18 +0000 (13:10 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 May 2014 19:18:24 +0000 (12:18 -0700)
Check the return values of dgap_tty_register and
dgap_finalize_board_init. If they fail for a
particular board we should not be able to try
to use that board. IE. no device entries shall
be created for that board.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgap/dgap.c

index 3b732380f9e6a49eb8821f9c9e720f8ba5c762ac..2c7acee6c926530b797e4009a78d2bb14f3894d9 100644 (file)
@@ -882,8 +882,13 @@ static int dgap_firmware_load(struct pci_dev *pdev, int card_type)
                return -EINVAL;
        }
 
-       dgap_tty_register(brd);
-       dgap_finalize_board_init(brd);
+       ret = dgap_tty_register(brd);
+       if (ret)
+               return ret;
+
+       ret = dgap_finalize_board_init(brd);
+       if (ret)
+               return ret;
 
        if (fw_info[card_type].bios_name) {
                ret = request_firmware(&fw, fw_info[card_type].bios_name,