x86/PCI: pci quirks, fix pci refcounting
authorJiri Slaby <jirislaby@gmail.com>
Tue, 8 Sep 2009 10:16:18 +0000 (12:16 +0200)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Wed, 9 Sep 2009 21:11:02 +0000 (14:11 -0700)
Stanse found a pci reference leak in quirk_amd_nb_node.
Instead of putting nb_ht, there is a put of dev passed as
an argument.

http://stanse.fi.muni.cz/

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
arch/x86/kernel/quirks.c

index af71d06624bf5b70b5173ba29238c40b6c21c801..6c3b2c6fd77257d643e3eb666a3a1f36a9c29efa 100644 (file)
@@ -508,7 +508,7 @@ static void __init quirk_amd_nb_node(struct pci_dev *dev)
 
        pci_read_config_dword(nb_ht, 0x60, &val);
        set_dev_node(&dev->dev, val & 7);
-       pci_dev_put(dev);
+       pci_dev_put(nb_ht);
 }
 
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_K8_NB,