OMAP: DSS2: Fix crash when panel doesn't define enable_te()
authorTomi Valkeinen <tomi.valkeinen@nokia.com>
Tue, 8 Dec 2009 15:30:24 +0000 (17:30 +0200)
committerTomi Valkeinen <tomi.valkeinen@nokia.com>
Fri, 8 Jan 2010 13:32:19 +0000 (15:32 +0200)
DSI driver didn't check if the panel driver actually implements
enable_te().

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
drivers/video/omap2/dss/dsi.c

index 03f85df707494db152523fa86ac5bf03cc76faaa..e32a53c0889f99011411d3877e42c5db5a4caa02 100644 (file)
@@ -2932,11 +2932,15 @@ static int dsi_set_update_mode(struct omap_dss_device *dssdev,
 
 static int dsi_set_te(struct omap_dss_device *dssdev, bool enable)
 {
-       int r;
-       r = dssdev->driver->enable_te(dssdev, enable);
-       /* XXX for some reason, DSI TE breaks if we don't wait here.
-        * Panel bug? Needs more studying */
-       msleep(100);
+       int r = 0;
+
+       if (dssdev->driver->enable_te) {
+               r = dssdev->driver->enable_te(dssdev, enable);
+               /* XXX for some reason, DSI TE breaks if we don't wait here.
+                * Panel bug? Needs more studying */
+               msleep(100);
+       }
+
        return r;
 }