liquidio: use fallback for selecting txq
authorSatanand Burla <satananda.burla@cavium.com>
Fri, 13 Jan 2017 00:18:22 +0000 (16:18 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 14 Jan 2017 01:17:35 +0000 (20:17 -0500)
Remove assignment to ndo_select_queue so that fallback is used for
selecting txq.  Also remove the now-useless function that used to be
assigned to ndo_select_queue.

Signed-off-by: Satanand Burla <satananda.burla@cavium.com>
Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
Signed-off-by: Derek Chickles <derek.chickles@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cavium/liquidio/lio_main.c
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c

index cc825d574e8e17aaa359dc5e14bd7fd4c5dce785..2b89ec291b8bd6f1f4ae67a7f31c5b8577a99275 100644 (file)
@@ -2223,25 +2223,6 @@ static void if_cfg_callback(struct octeon_device *oct,
        wake_up_interruptible(&ctx->wc);
 }
 
-/**
- * \brief Select queue based on hash
- * @param dev Net device
- * @param skb sk_buff structure
- * @returns selected queue number
- */
-static u16 select_q(struct net_device *dev, struct sk_buff *skb,
-                   void *accel_priv __attribute__((unused)),
-                   select_queue_fallback_t fallback __attribute__((unused)))
-{
-       u32 qindex = 0;
-       struct lio *lio;
-
-       lio = GET_LIO(dev);
-       qindex = skb_tx_hash(dev, skb);
-
-       return (u16)(qindex % (lio->linfo.num_txpciq));
-}
-
 /** Routine to push packets arriving on Octeon interface upto network layer.
  * @param oct_id   - octeon device id.
  * @param skbuff   - skbuff struct to be passed to network layer.
@@ -3755,7 +3736,6 @@ static const struct net_device_ops lionetdevops = {
        .ndo_set_vf_vlan        = liquidio_set_vf_vlan,
        .ndo_get_vf_config      = liquidio_get_vf_config,
        .ndo_set_vf_link_state  = liquidio_set_vf_link_state,
-       .ndo_select_queue       = select_q
 };
 
 /** \brief Entry point for the liquidio module
index ad2e72d7d522ce0d4c94ad928c3e1e2d01004f2d..19d88fb387cec7663659484f6cec7d4c0bd68ed7 100644 (file)
@@ -1455,26 +1455,6 @@ static void if_cfg_callback(struct octeon_device *oct,
        wake_up_interruptible(&ctx->wc);
 }
 
-/**
- * \brief Select queue based on hash
- * @param dev Net device
- * @param skb sk_buff structure
- * @returns selected queue number
- */
-static u16 select_q(struct net_device *dev, struct sk_buff *skb,
-                   void *accel_priv __attribute__((unused)),
-                   select_queue_fallback_t fallback __attribute__((unused)))
-{
-       struct lio *lio;
-       u32 qindex;
-
-       lio = GET_LIO(dev);
-
-       qindex = skb_tx_hash(dev, skb);
-
-       return (u16)(qindex % (lio->linfo.num_txpciq));
-}
-
 /** Routine to push packets arriving on Octeon interface upto network layer.
  * @param oct_id   - octeon device id.
  * @param skbuff   - skbuff struct to be passed to network layer.
@@ -2717,7 +2697,6 @@ static const struct net_device_ops lionetdevops = {
        .ndo_set_features       = liquidio_set_features,
        .ndo_udp_tunnel_add     = liquidio_add_vxlan_port,
        .ndo_udp_tunnel_del     = liquidio_del_vxlan_port,
-       .ndo_select_queue       = select_q,
 };
 
 static int lio_nic_info(struct octeon_recv_info *recv_info, void *buf)